Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Verified Packs #1749

Merged
merged 14 commits into from
Nov 8, 2023
Merged

Document Verified Packs #1749

merged 14 commits into from
Nov 8, 2023

Conversation

ritawatson
Copy link
Contributor

@ritawatson ritawatson commented Nov 2, 2023

Describe the Change

This PR adds a doc page to describe Verified Packs, how Palette displays them, and their update schedule.
This PR also reformats bullet lists as tables in the Maintenance Policy doc for easier readability.

Review Changes

💻 Verified Packs
Maintenance Policy

🎫 DOC-904

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for docs-spectrocloud ready!

Name Link
🔨 Latest commit c1acfa1
🔍 Latest deploy log https://app.netlify.com/sites/docs-spectrocloud/deploys/654bed0a7422180008e8dc71
😎 Deploy Preview https://deploy-preview-1749--docs-spectrocloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ritawatson ritawatson added the documentation Improvements or additions to documentation label Nov 2, 2023
@ritawatson ritawatson changed the title Draft verified packs, add screenshot Document Verified packs Nov 2, 2023
@ritawatson ritawatson changed the title Document Verified packs Document Verified Packs Nov 2, 2023
@ritawatson ritawatson added 4.0 4.0 Release 4.1 4.1 Release backport-version-4-0 Backport change to version 4.0 auto-backport Enable backport backport-version-4-1 Backport change to version 4.1 and removed 4.0 4.0 Release 4.1 4.1 Release labels Nov 2, 2023
@ritawatson ritawatson marked this pull request as ready for review November 3, 2023 00:13
@ritawatson ritawatson requested a review from a team as a code owner November 3, 2023 00:13
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Images automagically compressed by Calibre's image-actions

Compression reduced images by 34%, saving 31.16 KB.

Filename Before After Improvement Visual comparison
static/assets/docs/images/integrations_verified-packs-green-check.png 91.66 KB 60.50 KB -34.0% View diff

506 images did not require optimisation.

Copy link
Contributor

@lennessyy lennessyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added a few suggestions.

docs/docs-content/integrations/maintenance-policy.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/maintenance-policy.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/maintenance-policy.md Outdated Show resolved Hide resolved
@karl-cardenas-coding
Copy link
Contributor

@ritawatson We can probably remove the word Palette before verified packs. It feels redundant, especially in the navigation bar title.

docs/docs-content/integrations/verified_packs.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/verified_packs.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/verified_packs.md Outdated Show resolved Hide resolved
docs/docs-content/integrations/verified_packs.md Outdated Show resolved Hide resolved
Copy link
Contributor

@antongisli antongisli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a commit to verified_packs.md with some changes. otherwise LGTM

@ritawatson ritawatson merged commit a1daa3c into master Nov 8, 2023
10 checks passed
@ritawatson ritawatson deleted the verified-packs branch November 8, 2023 20:31
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 8, 2023
* Draft verified packs, add screenshot

* Replace bullet lists with tables

* Cross link two docs

* Ensure required language is used

* Fix typo

* Optimised images with calibre/image-actions

* Address review comments

* Incorporated more comments

* Revised info block about Support

* Update verified_packs.md

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: antongisli <anton@spectrocloud.com>
(cherry picked from commit a1daa3c)
vault-token-factory-spectrocloud bot pushed a commit that referenced this pull request Nov 8, 2023
* Draft verified packs, add screenshot

* Replace bullet lists with tables

* Cross link two docs

* Ensure required language is used

* Fix typo

* Optimised images with calibre/image-actions

* Address review comments

* Incorporated more comments

* Revised info block about Support

* Update verified_packs.md

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: antongisli <anton@spectrocloud.com>
(cherry picked from commit a1daa3c)
@vault-token-factory-spectrocloud
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
version-4-0
version-4-1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

ritawatson added a commit that referenced this pull request Nov 8, 2023
* Draft verified packs, add screenshot

* Replace bullet lists with tables

* Cross link two docs

* Ensure required language is used

* Fix typo

* Optimised images with calibre/image-actions

* Address review comments

* Incorporated more comments

* Revised info block about Support

* Update verified_packs.md

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: antongisli <anton@spectrocloud.com>
(cherry picked from commit a1daa3c)

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
ritawatson added a commit that referenced this pull request Nov 8, 2023
* Draft verified packs, add screenshot

* Replace bullet lists with tables

* Cross link two docs

* Ensure required language is used

* Fix typo

* Optimised images with calibre/image-actions

* Address review comments

* Incorporated more comments

* Revised info block about Support

* Update verified_packs.md

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: antongisli <anton@spectrocloud.com>
(cherry picked from commit a1daa3c)

Co-authored-by: Rita Watson <117382432+ritawatson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Enable backport backport-version-4-0 Backport change to version 4.0 backport-version-4-1 Backport change to version 4.1 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants